fix(crud): using metadata to update entities based on primary key instead of "found" #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschoeni
force-pushed
the
fix/117-eager-breaks-update
branch
3 times, most recently
from
c105d02 to
78c08ab
Compare
dschoeni
force-pushed
the
fix/117-eager-breaks-update
branch
from
78c08ab to
dd9dd51
Compare
dschoeni
changed the title
dschoeni
force-pushed
the
fix/117-eager-breaks-update
branch
from
dd9dd51 to
2fcffae
Compare
dschoeni
force-pushed
the
fix/117-eager-breaks-update
branch
from
2fcffae to
580c19a
Compare
|
Released via rewiko#5, https://www.npmjs.com/package/@rewiko/crud version 5.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this fix for issue #177.
{ ...found }I've added the primary keys to the object, so that only properties from the DTO are actually passed.Sorry for the messy process, I made some iterations on this to keep the fix as simple as possible.